Validate OGC API - Records #5
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-mohr
commented
Oct 31, 2024
| @@ -8,13 +8,24 @@ const { | |||
| THEMES_SCHEME | |||
| } = require('./definitions.js'); | |||
|
|
|||
| const RECORDS_CONFORMANCE_CLASS = "http://wis.wmo.int/spec/wcmp/2/conf/core"; // todo | |||
There was a problem hiding this comment.
This should be the OGC API - Records - Part 1: Core conformance class, I think, but the example doesn't have it.
See also: ESA-EarthCODE/open-science-catalog-metadata#233 (comment)
m-mohr
force-pushed
the
validate-records2
branch
from
358c226 to
7bf896c
Compare
m-mohr
commented
Oct 31, 2024
| @@ -0,0 +1,775 @@ | |||
| { | |||
| "$schema": "http://json-schema.org/draft-07/schema#", | |||
There was a problem hiding this comment.
Had to change the JSON Schema version to draft-07 as 202012 is not supported by stac-node-validator right now, shouldn't change anything though.
We should probably update the file if updates come in etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chose a different approach than initially explored in #3 - this seems simpler and has less drawbacks, I think.
I tested it against an invalid version of the example and it reported an error and suceeds otherwise.
Just a couple of comments below on issues that need to be clarified before merging.